-
Couldn't load subscription status.
- Fork 50
[issuegenerator] Ping pr author of failing test #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issuegenerator] Ping pr author of failing test #1267
Conversation
7d09c01 to
90d5bb6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
- Coverage 62.44% 61.33% -1.11%
==========================================
Files 65 65
Lines 4026 4172 +146
==========================================
+ Hits 2514 2559 +45
- Misses 1280 1377 +97
- Partials 232 236 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This does not seem to work in practice 🤔 Example workflow: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18347481850/job/52259572883 There are two issues, the first one is a permissions issue: The second one is that the comments do not seem to have the PR number, see open-telemetry/opentelemetry-collector-contrib#43116 (comment) I can try and look at the first one, but I don't understand why the second one happened. @jelly-afk do you want to take a look? |
Sorry, forgot to add pr number in comment template |
|
About the workflow failing to comment on pr, from what i could find its a permission issue and adding I will open a pr in contrib for this. |
…43500) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Added pull-request write permission to issuegenerator workflow, currently workflow fails to comment on pr because workflow does not have required permission. Link to workflow: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18347481850/job/52259572883 Discussion: open-telemetry/opentelemetry-go-build-tools#1267 (comment) cc @mx-psi
…pen-telemetry#43500) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Added pull-request write permission to issuegenerator workflow, currently workflow fails to comment on pr because workflow does not have required permission. Link to workflow: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/18347481850/job/52259572883 Discussion: open-telemetry/opentelemetry-go-build-tools#1267 (comment) cc @mx-psi
fixes #1182
autogenerated issues/comments now contain pr number of a failing test's pr
issuegenerator now pings author of a failing test's pr